Add touch event listeners for mobile movement tracking in speed modifier component (again)#20
Merged
MakingSpiderSense merged 3 commits intoJun 17, 2026
Conversation
MakingSpiderSense
deleted the
bugfix/movement-speed-modifier/118-show-speed-lines-on-mobile
branch
There was a problem hiding this comment.
Pull request overview
This PR improves mobile support for the movement-speed-modifier A-Frame component by tracking touch input and using it as an additional “moving forward” signal so the speed-lines effect can appear while moving on mobile.
Changes:
- Track active touches via a new
touchCountstate, updated bytouchstart/touchend/touchcancelhandlers. - Add/remove global touch event listeners during the component lifecycle (
init/remove). - Update
isMovingForward()to treat exactly one touch as forward movement so speed lines can be shown appropriately on mobile.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+271
to
+274
| onTouchStart: function (event) { | ||
| this.touchCount = event.touches.length; | ||
| this.syncSpeedLinesVisibility(); | ||
| }, |
Comment on lines
+283
to
+286
| onTouchEnd: function (event) { | ||
| this.touchCount = event.touches.length; | ||
| this.syncSpeedLinesVisibility(); | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves support for mobile touch input to the
movement-speed-modifiercomponent. The main changes include tracking touch events, updating movement logic to recognize touch-based movement, and ensuring that speed lines show up when moving forward on mobile.Mobile touch input support:
touchCountproperty and methods (onTouchStart,onTouchEnd) to track the number of fingers on the screen, and update movement state accordingly. [1] [2]addTouchListenersandremoveTouchListenersmethods to manage touch event listeners during component lifecycle. [1] [2]Movement logic updates:
isMovingForwardmethod to support forward movement when one finger is on the screen (two fingers moves the player backwards, so that would register asfalse), allowing for mobile-friendly movement controls.Trello: https://trello.com/c/GmhnPkKL
(Resubmitting this PR - see for details)